Gw 192 symspell pred time (#1) #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add DAMERAUOSAPYX to DistanceAlgorithm * add DamerauOSAWeightened * fixed missing editdistance * add keyboarddistance * add AbstractDistanceComparer to EditDistance * added optional normalisation of char weights * removed dist weights for transpositions * updated weights normalisation * changed tokenizer to toktok * add poetry toml * removed AbstractDistanceComparer * put back AbstractDistanceComparer into EditDistance init Co-authored-by: Łukasz Sawaniewski <[email protected]>
|
Thank you for the PR, however I would like to keep the library lean and not add to many extra dependencies. Custom edit distance comparers are officially supported with this PR #159 so you should be able to use the distance comparers you have implement in this PR for you use cases without having to modify Feel free to raise an issue if you encounter any problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add DAMERAUOSAPYX to DistanceAlgorithm
add DamerauOSAWeightened
fixed missing editdistance
add keyboarddistance
add AbstractDistanceComparer to EditDistance
added optional normalisation of char weights
removed dist weights for transpositions
updated weights normalisation
changed tokenizer to toktok
add poetry toml
removed AbstractDistanceComparer
put back AbstractDistanceComparer into EditDistance init