seibu/feversoc.cpp: Minor cleanups #14283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
Oct 7, 2025
cam900
commented
- Fix sprite wraparound method
- Add notes for sprite hardware
- Use BIT macro for single bit values
- Simplify gfx decode layout
- Fix spacings
- Fix namings
- Fix sprite wraparound method - Add notes for sprite hardware - Use BIT macro for single bit values - Simplify gfx decode layout - Fix spacings - Fix namings
angelosa
reviewed
Oct 9, 2025
src/mame/seibu/feversoc.cpp
Outdated
| const u32 colour = (m_spriteram[offs + 0] & 0x003f0000) >> 16; | ||
| const u8 w = ((m_spriteram[offs + 0] & 0x07000000) >> 24) + 1; | ||
| const u8 h = ((m_spriteram[offs + 0] & 0x70000000) >> 28) + 1; | ||
| // TODO: flip sprite? |
There was a problem hiding this comment.
The unused bits could be anything in the Seibu portfolio, adding this note has no effective value.
There was a problem hiding this comment.
That because original RISE11 (also used at rfjet and clones in seibu/seibuspi.cpp; including functionally compatible RISE10 and SEI252) has per-sprite flip X/Y bit in sprite RAM, but seems to not used in feversoc.
There was a problem hiding this comment.
So the note should be // TODO: merge implementation with Seibu SPI/Cats, and I don't think it's necessary because it's already repeated in header. Game probably also uses DMA start address etc. as per the norm since legionna.cpp anyway ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.