Skip to content

Clarify accepted output metric null semantics#222

Merged
malon64 merged 2 commits intomainfrom
agent/po-floe-20260313-1315-metrics-semantics-v2
Mar 13, 2026
Merged

Clarify accepted output metric null semantics#222
malon64 merged 2 commits intomainfrom
agent/po-floe-20260313-1315-metrics-semantics-v2

Conversation

@malon64
Copy link
Owner

@malon64 malon64 commented Mar 13, 2026

Summary

  • make accepted-output report metrics preserve null for unknown values and exact 0 for computed zeroes
  • apply the shared contract across Parquet, Delta, and Iceberg metric mapping paths
  • add focused docs and tests for serialization and sink-specific metric branches

Validation

  • cargo fmt
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test -p floe-core --test unit unit::io::write::metrics:: -- --nocapture
  • cargo test -p floe-core --test unit unit::report::accepted_output:: -- --nocapture
  • cargo test -p floe-core --test unit unit::io::write::delta_write::delta_commit_metrics_from_log_bytes_ -- --nocapture
  • cargo test -p floe-core --test unit unit::io::write::iceberg_write::write_iceberg_table_ -- --nocapture
  • cargo test -p floe-core --test unit unit::run::report:: -- --nocapture
  • cargo test -p floe-core --test integration local_run_parquet_metrics_track_chunked_output_files -- --nocapture
  • cargo test -p floe-core --test integration local_delta_run_respects_partition_by_and_reports_metrics -- --nocapture
  • cargo test -p floe-core --test integration local_run_writes_iceberg_table_and_report_fields -- --nocapture
  • cargo test -p floe-cli --test output -- --nocapture

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20d0ae5410

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@malon64 malon64 merged commit 3ceb9b0 into main Mar 13, 2026
3 checks passed
@malon64 malon64 deleted the agent/po-floe-20260313-1315-metrics-semantics-v2 branch March 13, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant