feat(core): configurable merge options for Delta merge modes#202
Merged
feat(core): configurable merge options for Delta merge modes#202
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80e6070833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
80e6070 to
396a947
Compare
396a947 to
6dc17bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sink.accepted.mergeconfig for Delta merge write modes with:ignore_columnscompare_columnsscd2.current_flag_column,scd2.valid_from_column,scd2.valid_to_columnmergeis omitted, merge behavior remains unchangedignore_columnsfrom update setcompare_columnsif provided; else non-key business columns minusignore_columns)Validation Rules
sink.accepted.mergeis only valid when:sink.accepted.format = deltasink.write_modeismerge_scd1ormerge_scd2ignore_columnsandcompare_columnsmust exist in schemaschema.primary_key) are forbidden inignore_columnsandcompare_columnsmerge.scd2options are only allowed withmerge_scd2Defaults and Migration Notes
__floe_is_current__floe_valid_from__floe_valid_tosink.accepted.mergeDocs
docs/config.mdwithsink.accepted.mergeblock and examplesdocs/write_modes.mdwith merge option semanticsdocs/design/merge_strategy_architecture.mdTests
crates/floe-core/tests/unit/config/crates/floe-core/tests/integration/delta_run.rsfor:mergeblock is absentValidation
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test --all