This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Code Cleanup #43
Open
Code Cleanup #43
+16
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the `timer` variable was being initialized in the `_handleSpy` function it would be a new variable each time it was called so the `if (timer)` check would always fail.
if we set it to an empty string by default we dont need to check if it got passed in.
if the only item in the template string is a variable is then you can just use the variable directly
passing `this.props.className` on to the `Tag` will function the same.
We dont need an extra check to see if its truthy since we want to pass whatever classname they already had straight through
This way we dont need to worry about passing all existing props since cloneElement we keep all existing props and just override props that are passed (in this case just className)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the great lib. I did a cleanup locally and figured I'd push it up so you can see what I did (and if you like it merge it in 😄).
None of the changes I made should alter any of the existing behavior. If you find any differences please let me know.
I did the cleanup in a bunch of steps and annotated each commit with what was changed and why.
Thanks again for the lib and let me know what you think...