feat: adds ability for temporary activation for user #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 87.28% 87.31% +0.03%
==========================================
Files 163 163
Lines 3153 3170 +17
==========================================
+ Hits 2752 2768 +16
- Misses 401 402 +1
Continue to review full report at Codecov.
|
AVVS
reviewed
Mar 10, 2021
src/actions/register.js
Outdated
| internal: true, | ||
| }, | ||
| }); | ||
| await assignAlias.call(service, { params: { username, alias, internal: true } }); |
There was a problem hiding this comment.
maybe its better to use service.dispatch so that validation & other middleware is triggered during this actiion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.