feat: abstract DB Adapter #112

AVVS · 2016-06-03T09:23:25Z

No description provided.

…storage

…chema

codecov-io · 2016-06-03T09:24:40Z

Current coverage is 88.45% (diff: 90.21%)

Merging #112 into master will decrease coverage by 0.65%

@@             master       #112   diff @@
==========================================
  Files            36         38     +2   
  Lines           744        823    +79   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            663        728    +65   
- Misses           81         95    +14   
  Partials          0          0

Powered by Codecov. Last update 6b0a659...98b5770

…n Redis and the whole code

code was linted, docker script was adapted to MS Windows

…odule, new remapMeta util, upda

…; actions: remove, requestPassw

AVVS · 2016-06-20T10:05:53Z

/home/runner/ms-users/src/actions/register.js
  12:23  error  Unable to resolve path to module '../db/adapter'  import/no-unresolved

/home/runner/ms-users/src/model/storages/redisstorage.js
  42:25  error  'captchaConfig' is defined but never used           no-unused-vars
  43:9   error  'deleteInactiveAccounts' is defined but never used  no-unused-vars

ну да, всему виной actions/register, а он пока на операционном столе

AVVS · 2016-06-20T10:09:15Z

@stainwoortsel относительно ошибок ремаппинг мы будем делать не каждый раз после каждого метода, а 1 раз во время ответа, есть возможность добавить функцию onComplete(err, data, actionName, actions), где err - ошибка, data - когда собственно ее нет, actionName - название события, actions - чаще всего undefined, а когда в AMQP QOS включен, то там ack/reject/retry

https://github.com/makeomatic/mservice/blob/master/src/plugins/amqp.js#L84-L94

AVVS · 2016-06-20T10:11:51Z

src/model/usermodel.js

 }

 module.exports.User = new UserModel(storage.User);
 module.exports.Attempts = new AttemptsHelper(storage.Attempts);
+module.exports.Tokens = new TokensHelper(storage.Tokens);


можно сократить и просто писать

exports.User = ...
exports.Attempts = ...

То есть Attempts и Tokens в классы не оборачивать?
Можно, но этж типа абстракция ) мало ли чего мы захотим вписать в методы по дефолту
Плюс оно обеспечивает требование по наличию в "стороже" нужных методов на этапе (типа) компиляции.
...ну не компиляции, но ошибка сразу найдется -- я к чему ) конечно, тесты -- дело святое, но так на ошибку наткнешься сразу и носом, еще на уровне линтера

да не, я имею ввиду не нужно писать module.exports.SMTH =
пиши просто exports.SMTH =

-module.exports.User = new UserModel(storage.User); +exports.User = new UserModel(storage.User);

onComplete -- это, я так понимаю, в настройках defaults.js, в разделе amqp?

Все верно. Либо можем добавить хуки специальные в mservice по аналогии с hapi.js - там неплохо сделано, но это уже позже

да не, я имею ввиду не нужно писать module.exports.SMTH =
пиши просто exports.SMTH =

а... ок )

…ls: send-email

…rage, model/usermodel

ghost · 2016-06-21T00:52:30Z

Так.. вижу branch conflict, но ветки я пока не мёржу.
Расскажу в общих чертах об изменениях:

да, класс с регистрацией сделал
перенес гугл-капчу в отдельную утилиту, тот код капчи что зависит от редиски -- в адаптере, в Utils. Гугл передается методу как функция-next) Utils.checkCaptcha.call(this, username, captcha, verifyGoogleCaptcha)`
Помимо register были правки в send-email, он оставался единственным где был redis, не уверен что сделал его чисто

AVVS · 2016-06-23T23:23:20Z

test/docker.sh

  chmod +x $DIR/.bin/docker-compose
-  COMPOSE=$(which docker-compose)
+#  COMPOSE=$(which docker-compose)
+  COMPOSE="c:/dev/docker/docker-compose.exe"


ну да, так тесты и пройдут)

…ens, attempts

…age:getList

course, the key is in an abstraction. the user model abstraction now allows to make such operation

stainwoortsel added 2 commits June 3, 2016 04:34

feat(Adapter Class): The realisation of adapter class and Redis data …

757b931

…storage

feat(actions, adapter, redisstorage): Updating few actions with new s…

76cc264

…chema

stainwoortsel added 12 commits June 3, 2016 13:02

feat(adapter, redisstorage, actions): Making abstraction layer betwee…

fd2a23f

…n Redis and the whole code

style(gitignore):

c4ebf71

style(delete compiled and map files):

4b7a5c6

feat: actions: login, alias, list

a334384

feat: register action

98cf306

feat: add new utils: verifyGoogleCaptcha and mapMetaResponse

17ba3bf

feat: remove action

e04d2c7

feat: actions: requestPassword, updateMetadata

e113733

feat: actions: updatePassword, verify

0b51598

style: actions, adapter, redisstorage, utils, docker.sh

55c47af

code was linted, docker script was adapted to MS Windows

feat: new UserModer class abstraction, redisstorage, new modelError m…

b18ac68

…odule, new remapMeta util, upda

feat: renewed modelError methods, usermodal, redisstodage; utils: jwt…

821deb6

…; actions: remove, requestPassw

AVVS reviewed Jun 20, 2016
View reviewed changes

stainwoortsel added 2 commits June 21, 2016 03:32

feat: usermodel & redisstorage: throttle state and token methods, uti…

8a5de75

…ls: send-email

style: some linter fixes: util/scrypt, util/send-emal, model/redissto…

3829f5e

…rage, model/usermodel

fix: fixing docker.sh

60746e9

AVVS reviewed Jun 23, 2016
View reviewed changes

AVVS and others added 6 commits June 26, 2016 20:45

Merge branch 'master' into adapter

6ba80a6

fix: fixing 'this'-context trouble, fixing loginAttempts variable

0dfc8c9

fix: fixing bugs through the tests

e4c8b44

fix: linting!

ac18064

fix: fixing bugs through tests

71aa982

fix: linting!

2ee6993

stainwoortsel added 17 commits July 1, 2016 06:56

fix: fixing register bug with catchReturn wrong error code

275a7bb

fix: fixing bugs through the tests

7d5a1f2

fix: fixing bugs through the tests

8b7263d

fix: fixing bugs through the tests: usermodel, login, updateMeta, tok…

0860363

…ens, attempts

fix: jwt logout decodedTokens, arrow-function better

12c5df1

fix: fixing bugs through the tests: jwt/send-mail

7d7bfb4

fix: fixing bugs through the test (hope, in last time): jwt, send-mail

785ccfd

fix: some cosmetic fixes

8ea411f

fix: some another cosmetic fixes

d6cff19

refactor: merging with master

7cc68c8

fix: UNIX-style end of strings in scripts (to avoid bash errors)

1cabd9c

fix: some lint sugar

71c46a5

fix: and little fix for math operation with page of list in redisstor…

db222e4

…age:getList

fix: please linter, please...

aaad1a4

feat: mongo docker-compose

98b5770

feat: making test suites a bit more independed from storages

20fa21d

course, the key is in an abstraction. the user model abstraction now allows to make such operation

feat: methods in mongo adapter, before HUGE refactoring commit

24e3674

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: abstract DB Adapter #112

feat: abstract DB Adapter #112

AVVS commented Jun 3, 2016

codecov-io commented Jun 3, 2016 •

edited

Loading

AVVS commented Jun 20, 2016 •

edited by ghost

Loading

AVVS commented Jun 20, 2016

AVVS Jun 20, 2016

ghost Jun 20, 2016 •

edited by ghost

Loading

AVVS Jun 20, 2016 •

edited

Loading

ghost Jun 20, 2016

AVVS Jun 20, 2016

ghost Jun 20, 2016

ghost commented Jun 21, 2016

AVVS Jun 23, 2016

feat: abstract DB Adapter #112

Are you sure you want to change the base?

feat: abstract DB Adapter #112

Conversation

AVVS commented Jun 3, 2016

codecov-io commented Jun 3, 2016 • edited Loading

Current coverage is 88.45% (diff: 90.21%)

AVVS commented Jun 20, 2016 • edited by ghost Loading

AVVS commented Jun 20, 2016

AVVS Jun 20, 2016

Choose a reason for hiding this comment

ghost Jun 20, 2016 • edited by ghost Loading

Choose a reason for hiding this comment

AVVS Jun 20, 2016 • edited Loading

Choose a reason for hiding this comment

ghost Jun 20, 2016

Choose a reason for hiding this comment

AVVS Jun 20, 2016

Choose a reason for hiding this comment

ghost Jun 20, 2016

Choose a reason for hiding this comment

ghost commented Jun 21, 2016

AVVS Jun 23, 2016

Choose a reason for hiding this comment

codecov-io commented Jun 3, 2016 •

edited

Loading

AVVS commented Jun 20, 2016 •

edited by ghost

Loading

ghost Jun 20, 2016 •

edited by ghost

Loading

AVVS Jun 20, 2016 •

edited

Loading