Skip to content

feat(desktop): add safe iOS Simulator deletion #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaoWeiLiuXD merged 1 commit into from
Sep 2, 2026
Merged

feat(desktop): add safe iOS Simulator deletion #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/desktop/src/main/doc-tools/__tests__/docsOutputWriterUtilityProcess.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ describe('docs output cwd-bound writer', () => {
`
const fs = (await import('node:fs')).default;
const path = (await import('node:path')).default;
const { runDocsOutputWrite } = await import(process.env.CINDY_WRITER_MODULE);
const writerModule = await import(process.env.CINDY_WRITER_MODULE);
const { runDocsOutputWrite } = writerModule.default ?? writerModule;
const root = process.env.CINDY_WRITER_ROOT;
const safe = process.env.CINDY_WRITER_SAFE;
const moved = process.env.CINDY_WRITER_MOVED;
Expand Down
14 changes: 13 additions & 1 deletion apps/desktop/src/main/maker-ipc/__tests__/iosSimulatorHandlers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,18 @@ describe('iOS Simulator IPC handlers', () => {
}),
).resolves.toMatchObject({ ok: true });
expect(callTool).toHaveBeenCalledWith('attach_device', {}, 'session-a');
await expect(
harness.invokeFrom(17, MAKER_INVOKE.IOS_SIMULATOR_CALL, {
sessionId: 'session-a',
name: 'delete_instance',
args: { instanceId: 'instance-a', generation: 2, leaseId: 'lease-a' },
}),
).resolves.toMatchObject({ ok: true });
expect(callTool).toHaveBeenCalledWith(
'delete_instance',
{ instanceId: 'instance-a', generation: 2, leaseId: 'lease-a' },
'session-a',
);
for (const name of ['build_app', 'open_url', 'push_notification', 'delete_everything']) {
await expect(
harness.invokeFrom(17, MAKER_INVOKE.IOS_SIMULATOR_CALL, {
Expand All @@ -648,7 +660,7 @@ describe('iOS Simulator IPC handlers', () => {
}),
).rejects.toMatchObject({ code: 'INVALID_PARAMS' });
}
expect(callTool).toHaveBeenCalledTimes(1);
expect(callTool).toHaveBeenCalledTimes(2);
});

it('folds tool-call internals behind the same safe Main-to-Renderer boundary', async () => {
Expand Down
Loading