Improve template usability and fix errors#1
Open
CreeperPookie wants to merge 4 commits intomakamys:masterfrom
Open
Improve template usability and fix errors#1CreeperPookie wants to merge 4 commits intomakamys:masterfrom
CreeperPookie wants to merge 4 commits intomakamys:masterfrom
Conversation
Author
|
was trying to rename my branch locally, forgot that would effect the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this template has saved me so much time compared to dealing with the official Forge MDK, something I immediately noticed was that it didn't work right off the bat - there were a lot of weird errors that weren't immediately obvious why were happening; So, I decided to fix them all :D
Specifically:
mcmod.infoactually refers tominecraft_version, notmcversion, so trying to expandmcversionreally doesn't make any sensegradlew buildcauses a large amount of errors, due to the effectively invalid syntaxExampleMod.javawasn't even in any package; even if it was expanded, it would evaluate topackage ;, which is obviously invalidpublic class foo.bar {}is not valid syntax)