Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in comment #252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typo in comment #252

wants to merge 1 commit into from

Conversation

MHMasoon
Copy link

No description provided.

@hdoordt
Copy link
Member

hdoordt commented Jan 28, 2025 •
edited
Loading

Hi @MHMasoon Thanks for helping out! This here's not actually a typo: 255 can't fit in an i8. Do you have any suggestions for improving the wording so it becomes more clear?

@MHMasoon
Copy link
Author

Hi @hdoordt,
I just made this comment the same as it is in the "solutions" branch. 255u8 can't fit in an i8 but can be converted to it when #[allow(overflowing_literals)] is used; that's what the comment suggests.
As for making it more clear, I don't have any suggestions, but I think the current version encourages students to explore and find the solution. A more explicit comment might spoon-feed them the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MHMasoon @hdoordt