Skip to content

Conversation

@eflukx
Copy link

@eflukx eflukx commented Sep 29, 2025

Since long time (see #253 and 646041b) Client uses the defaults configured using the Mailgun.configure block. Somehow it skips the setup of test_mode. As it can be set in the global configuration, this seems to be an inconsistency.

@eflukx
Copy link
Author

eflukx commented Sep 29, 2025

Another possible (but api-breaking) change is to use named parameters in the initialize method. e.g.

    def initialize(api_key: Mailgun.api_key,
                   api_host: Mailgun.api_host || 'api.mailgun.net',
                   api_version: Mailgun.api_version  || 'v3',
                   ssl: true,
                   test_mode: !!Mailgun.test_mode,
                   timeout: nil,
                   proxy_url: Mailgun.proxy_url)

@alex-leb alex-leb self-assigned this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants