Skip to content

CI improvements#111

Merged
ddrcode merged 3 commits intomaiko-rs:mainfrom
vnermolaev:issue-106
Mar 18, 2026
Merged

CI improvements#111
ddrcode merged 3 commits intomaiko-rs:mainfrom
vnermolaev:issue-106

Conversation

@vnermolaev
Copy link
Copy Markdown
Contributor

@vnermolaev vnermolaev commented Mar 10, 2026

Addresses #106 by

  • fixing CI failure.
  • adjusting events on which CI runs.

Suggestions

  • use nextest, it's much faster that simply cargo test.
  • use taplo to introduce unified formatting also for toml files.

If you like any (or both) of these suggestion, I will add them to this PR as separate commits.

* Adjust when CI runs.
@ddrcode
Copy link
Copy Markdown
Member

ddrcode commented Mar 16, 2026

Thank you @vnermolaev . I will be reviewing the PRs this evening.

@ddrcode ddrcode self-requested a review March 16, 2026 11:05
@ddrcode
Copy link
Copy Markdown
Member

ddrcode commented Mar 16, 2026

Adding taplo definitely makes sense to me. Having unified toml files helps. I am not sure about nexttest, as we don't have massive number of tests. But, I assume, you already have a good experience with it. If you see the value, I am fine to add it too.

If you are familiar with Nix, please add the new dependencies to flake.nix

@vnermolaev
Copy link
Copy Markdown
Contributor Author

vnermolaev commented Mar 16, 2026

I am not sure about nexttest, as we don't have massive number of tests.

nextest only tests binaries, while test also executes doc-tests. With this in mind, I verified locally that savings using nextest are currently marginal (although the output is much nicer :). I am postponing it.

If you are familiar with Nix, please add the new dependencies to flake.nix

I am not familiar. TBH, I'd like to keep time investment in infra limited, IMO, the basics are covered with this setup.

Adding taplo definitely makes sense to me.

I added some basic formatting, feel free to tweak the config to your liking.

@vnermolaev
Copy link
Copy Markdown
Contributor Author

👀

Copy link
Copy Markdown
Member

@ddrcode ddrcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. Thank you for contribution!

@ddrcode ddrcode linked an issue Mar 18, 2026 that may be closed by this pull request
@ddrcode ddrcode merged commit 203585e into maiko-rs:main Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Repo maintenance] Basic sanity check

2 participants