Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Addresses #25.
Before this PR, there was no global stop-gate protecting Stage-1 producers.
Shutdown relied on broker-side timeout heuristics (10ms + 100us sleep loops), which is fragile under load.
PR changes
CancellationToken) shared bySupervisorand actorContext.internal::gated_sendfor shutdown-aware Stage-1 send:reserve().awaitpermit.send(...)(this is sync, so definitely nothing can get queued)gated_send:Context::send_envelopeSupervisor::sendSupervisor::stop.sender.next()returnsNone.Why this addresses the race
Previously, lack of a stop-gate meant sends could slip through during shutdown transitions, and timeout polling tried to “wait enough.”
Now, shutdown is explicit and synchronized:
Status / caveat
@ddrcode This may not be the final ready-to-ship shutdown model, but it is a promising direction aligned with the ticket: it removes magic timing assumptions and introduces explicit coordination.
Extension path to multiple brokers
The same model scales:
This keeps shutdown semantics explicit and composable as broker count grows.