Skip to content

Conversation

@magniloquency
Copy link
Owner

No description provided.

@magniloquency magniloquency force-pushed the ymq-tests branch 3 times, most recently from 80516b3 to 5db358e Compare August 19, 2025 02:05
@gxuu
Copy link
Collaborator

gxuu commented Aug 19, 2025

I know this is a WIP here, just putting a few notes.

When it's done, all the testing code should be using gtest and reside in the parallel directory in /tests instead of the code directory. So something like PROJECT_DIR/tests/io/ymq/. The corresponding directory's cmake should be updated as well. This is because we don't package tests when releasing. Also test should be auto triggered when running ctest.

tests should be grouped to suite and cases. I'd say all the tests you've written as of now can be put in just one suite, and then later we will have nuance tests that involve the TCP protocol and that would better be put into another suite.

Changes to Bytes should not change it's behavior where the core uses it. Non-affecting changes are perfectly fine.

timestamp might be your friend, if you are dealing with itimerspec. It does easy conversion to itimerspec for you.

@magniloquency magniloquency force-pushed the integrate-ymq branch 7 times, most recently from 0845b6d to 2946a98 Compare September 5, 2025 03:19
@magniloquency magniloquency force-pushed the ymq-tests branch 2 times, most recently from 02d8767 to e86f21e Compare September 5, 2025 04:47
@magniloquency magniloquency changed the base branch from integrate-ymq to ymq-pymod-fixes September 5, 2025 04:47
@magniloquency magniloquency force-pushed the ymq-pymod-fixes branch 4 times, most recently from 52d5efa to 99fc599 Compare September 8, 2025 22:58
@magniloquency magniloquency force-pushed the ymq-tests branch 4 times, most recently from 38d78ba to a1e64b2 Compare September 8, 2025 23:27
@magniloquency magniloquency force-pushed the ymq-tests branch 3 times, most recently from 1526a8f to b9fe7c0 Compare September 9, 2025 00:59
@magniloquency magniloquency force-pushed the ymq-tests branch 2 times, most recently from e81a382 to 041ffab Compare September 29, 2025 14:23
gxuu and others added 2 commits September 29, 2025 16:25
* Switch NULLs to nullptrs

Signed-off-by: gxu <[email protected]>

* Resolve comment for mag

Signed-off-by: gxu <[email protected]>

* No check for resource allocation

Signed-off-by: gxu <[email protected]>

---------

Signed-off-by: gxu <[email protected]>
* Port Symphony worker to Symphony worker adapter

* Organize files

---------

Co-authored-by: sharpener6 <[email protected]>
@magniloquency magniloquency force-pushed the ymq-tests branch 17 times, most recently from 0d0f48f to 08e7ef4 Compare September 30, 2025 03:55
@magniloquency magniloquency force-pushed the ymq-tests branch 4 times, most recently from f25c7fd to 2e5737a Compare October 1, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants