Ymq bugs #12
Open
Ymq bugs #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make YMQ more ergonomic for use cases - Bytes `const std::string&` constructor for debug and testing usage - Bytes equality comparator - Extra error that likely helps user develop Signed-off-by: gxu <[email protected]> * Make YMQ more aligned to the MITM test It used to be the case that YMQ always tries to reconnect, but it turns out that we don't really need this: graceful disconnect are consider to be a real disconnect; while ungraceful reconnect (ECONNRESET) will trigers reconnect. Signed-off-by: gxu <[email protected]> * Swap Object Storage Server to use YMQ Signed-off-by: gxu <[email protected]> * Change signals to SIGKILL as YMQ doesn't support signal handling Signed-off-by: gxu <[email protected]> * Resolve comment for rafa Signed-off-by: gxu <[email protected]> --------- Signed-off-by: gxu <[email protected]>
Signed-off-by: gxu <[email protected]>
Signed-off-by: gxu <[email protected]>
Signed-off-by: gxu <[email protected]>
magniloquency
force-pushed
the
ymq-tests
branch
25 times, most recently
from
be9022c to
ebbfd94
Compare
magniloquency
force-pushed
the
ymq-tests
branch
7 times, most recently
from
2e5737a to
da33087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put some of the bug fixes in the main branch already and this is for you so that you can play with it, as we discussed last night.