Skip to content

Slightly updated dependencies and ripped out some files #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/androidx-migration
Choose a base branch
from

Conversation

alugocp
Copy link

@alugocp alugocp commented May 7, 2025

I updated the min SDK to 28 (Android 9), plus whatever else I had to do to get this compiling on a Samsung Galaxy S8. No hard feelings if it gets rejected, I see that you targeted an even older SDK and might not want it to lose support.

@magicsih magicsih requested a review from Copilot May 7, 2025 04:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the min SDK version to Android 9 (SDK 28) and removes some example test files to streamline the codebase for the Samsung Galaxy S8 compilation.

  • Updated dependency versions and SDK requirements
  • Removed ExampleUnitTest.java and ExampleInstrumentedTest.java files

Reviewed Changes

Copilot reviewed 6 out of 22 changed files in this pull request and generated no comments.

File Description
app/src/test/java/com/github/magicsih/androidscreencaster/ExampleUnitTest.java Test file removed; ensure alternative testing coverage is in place.
app/src/androidTest/java/com/github/magicsih/androidscreencaster/ExampleInstrumentedTest.java Test file removed; verify that essential instrumentation tests are maintained if needed.
Files not reviewed (16)
  • .idea/compiler.xml: Language not supported
  • .idea/copyright/profiles_settings.xml: Language not supported
  • .idea/deploymentTargetDropDown.xml: Language not supported
  • .idea/gradle.xml: Language not supported
  • .idea/jarRepositories.xml: Language not supported
  • .idea/misc.xml: Language not supported
  • .idea/modules.xml: Language not supported
  • .idea/runConfigurations.xml: Language not supported
  • .idea/vcs.xml: Language not supported
  • app/build.gradle: Language not supported
  • app/proguard-rules.pro: Language not supported
  • app/src/main/AndroidManifest.xml: Language not supported
  • app/src/main/res/layout/activity_main.xml: Language not supported
  • app/src/main/res/values-ko/strings.xml: Language not supported
  • gradle.properties: Language not supported
  • gradle/wrapper/gradle-wrapper.properties: Language not supported
Comments suppressed due to low confidence (2)

app/src/test/java/com/github/magicsih/androidscreencaster/ExampleUnitTest.java:1

  • Removing ExampleUnitTest.java may reduce unit test coverage; please ensure alternative tests exist or consider keeping the file if relevant.
package com.github.magicsih.androidscreencaster;

app/src/androidTest/java/com/github/magicsih/androidscreencaster/ExampleInstrumentedTest.java:1

  • Removing ExampleInstrumentedTest.java could lower instrumentation test coverage; please verify that critical device-level testing is still maintained.
package com.github.magicsih.androidscreencaster;

@magicsih magicsih changed the base branch from master to feature/androidx-migration May 14, 2025 05:01
@magicsih
Copy link
Owner

@alugocp

Thanks a lot for the PR and the thoughtful note!

This project has been inactive for quite a while, so I’ll need to test the changes before making any decisions about merging into master.

For now, I’ll merge your PR into a new branch: feature/androidx-migration, and will try to run and test it myself.

Since I currently don’t have an Android dev environment set up, it would be super helpful if you could share any test results, screenshots, or notes on how well it works on your device. That would help me decide if it’s safe to merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants