Fixed graceful shutdown #414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
bmuddha
reviewed
Jun 26, 2025
|
|
||
| pub struct Shutdown; | ||
| impl Shutdown { | ||
| pub async fn wait() -> Result<(), io::Error> { |
There was a problem hiding this comment.
nit: can't we just have a single function, without extra calls? Just having two wait methods with different cfgs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our validator doesn't handle SIGTERM, only SIGINT.
This pr adds handling of SIGTERM signal
Greptile Summary
Enhanced validator shutdown handling by adding SIGTERM support alongside SIGINT, implementing a dedicated shutdown module for more robust signal management and cleanup.
test-bins/src/shutdown.rsimplementing platform-aware signal handling for both SIGTERM and SIGINTtest-bins/src/rpc.rsto use the new Shutdown type for improved termination managementcfgattributes to support both Unix and non-Unix systems