chore: improved error logs + docs and naming

[thlorenz]

Summary

Improving error logs, documenting each instruction in more detail and normalizing the protocol
fees vault related instruction name.

Details

Error Logs

When an error occurred we would end up with just an error code and it was hard to understand
what went wrong. We now log error messages to include more information about the error
and the context in which it occurred, mainly a label and pubkey of the account in violation.

Documentation

Each instruction now has the following sections in the documentation:

• accounts: a list of accounts that are used by the instruction and if they need to be
  writable/signers
• requirements: a list of requirements that need to be met for the instruction to succeed,
  mainly relating to how the input accounts were setup previously
• steps: outlining what the instruction does (those were already there for most instructions,
  and were added to all remaining ones)

Greptile Summary

This PR enhances documentation and error logging across the delegation program, focusing on improved clarity and maintainability.

• Added comprehensive documentation sections for accounts, requirements, and execution steps across all processor functions
• Renamed InitFeesVault to InitProtocolFeesVault and related functions for better clarity
• Added descriptive labels to account validation functions for more informative error messages
• Fixed error enum name from Undelegatable to NotUndelegatable for clearer error messaging
• Added TODO comments flagging potential issues like obsolete fields and validation requirements

The changes are well-structured and improve code maintainability without introducing functional changes. However, the TODO comments should be addressed before merging.

[greptile-apps]

_{37 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile}

[GabrielePicco]

LGTM! Thanks