Reimplementation of the world program with Pinocchio #177

thewuhxyz · 2025-05-13T15:42:44Z

Status	Type	⚠️ Core Change	Issue
Ready	Feature	Yes	Nil

Problem

What problem are you trying to solve?

Anchor is not the most adequate for real-time systems on solana. Bloated, slow, expensive

Solution

How did you solve the problem?

Rewrite pieces of bolt with zero-copy pinocchio with full backwards compatiblity

Before & After Screenshots

Deploy Notes

cargo build-sbf over anchor build. anchor build for generating idls

New dependencies:

pinocchio : Pinocchio

Greptile Summary

This PR introduces a significant architectural change by implementing a Pinocchio-based alternative to the existing Anchor-based world program in the Bolt framework. The core motivation is performance optimization - addressing Anchor's limitations for real-time systems on Solana by replacing it with zero-copy operations.

Key Changes:

New Pinocchio World Program: A complete rewrite of the world program using the pinocchio framework, located in crates/pinocchio/world/. This includes all instruction handlers (add_entity, apply_system, initialize_component, etc.) rewritten with manual memory management and unsafe operations for performance.
CPI Interface Layer: A new bolt-cpi-interface crate that provides cross-program invocation interfaces for component operations (initialize, update, destroy) and system execution using Pinocchio's primitives instead of Anchor's CPI abstractions.
State Management Rewrite: Complete reimplementation of state structures (World, Entity, Registry, SystemWhitelist) using zero-copy Transmutable traits and manual discriminator handling.
Instruction Dispatching: Custom instruction dispatch system using u64 discriminators instead of Anchor's automatic deserialization, with manual byte parsing and unsafe pointer operations.

Architecture Integration:

The implementation maintains full backwards compatibility by preserving the same program ID, instruction discriminators, and account structures. This allows existing clients to work unchanged while benefiting from reduced compute unit costs. The new implementation coexists with the existing Anchor version, suggesting a gradual migration strategy where both can operate during the transition period.

The change affects the core ECS (Entity Component System) functionality of Bolt, including world management, entity creation, component lifecycle, and system execution - all critical paths for real-time blockchain gaming applications.

Confidence score: 1/5

This PR contains critical bugs that will cause runtime failures and prevent proper program execution
Multiple critical typos in discriminator constants create mismatches between instruction identification and execution paths
The combination of unsafe memory operations, complex manual memory management, and discriminator inconsistencies makes this unsafe to merge
Files with the most critical issues: crates/pinocchio/world/src/instructions/mod.rs, crates/pinocchio/world/src/state/world.rs, crates/pinocchio/world/src/consts.rs

greptile-apps

_{34 files reviewed, 20 comments}

_{Edit Code Review Bot Settings | Greptile}

greptile-apps · 2025-07-30T09:43:18Z

crates/pinocchio/world/src/instructions/mod.rs

+pub const ADD_AUTHORIITY_DISCRIMINATOR: u64 = 13217455069452700133;
+pub const REMOVE_AUTHORIITY_DISCRIMINATOR: u64 = 15585545156648003826;


syntax: Typo in constant names: 'AUTHORIITY' should be 'AUTHORITY'

Suggested change

pub const ADD_AUTHORIITY_DISCRIMINATOR: u64 = 13217455069452700133;

pub const REMOVE_AUTHORIITY_DISCRIMINATOR: u64 = 15585545156648003826;

pub const ADD_AUTHORITY_DISCRIMINATOR: u64 = 13217455069452700133;

pub const REMOVE_AUTHORITY_DISCRIMINATOR: u64 = 15585545156648003826;

greptile-apps · 2025-07-30T09:43:18Z

crates/pinocchio/world/src/instructions/mod.rs

+    ApproveSystem = APPROVE_SYSTEM_DISCRIMINATOR,
+    RemoveSystem = REMOVE_SYSTEM_DISCRIMINATOR,
+    AddEntity = ADD_ENTITY_DISCRIMINATOR,
+    InitilizeComponent = INITIALIZE_COMPONENT_DISCRIMINATOR,


syntax: Typo in enum variant: 'InitilizeComponent' should be 'InitializeComponent'

Suggested change

InitilizeComponent = INITIALIZE_COMPONENT_DISCRIMINATOR,

InitializeComponent = INITIALIZE_COMPONENT_DISCRIMINATOR,

greptile-apps · 2025-07-30T09:43:19Z

crates/pinocchio/world/src/consts.rs

@@ -0,0 +1 @@
+pub const DISCRIMATOR_LENGTH: usize = 8;


syntax: Typo in constant name: 'DISCRIMATOR_LENGTH' should be 'DISCRIMINATOR_LENGTH' (missing 'IN'). This matches the naming convention used elsewhere and fixes the spelling error.

Suggested change

pub const DISCRIMATOR_LENGTH: usize = 8;

pub const DISCRIMINATOR_LENGTH: usize = 8;

greptile-apps · 2025-07-30T09:43:28Z

crates/pinocchio/world/src/instructions/approve_system.rs

+    if *is_permissionless {
+        *is_permissionless = false
+    }


syntax: Missing semicolon after assignment

Suggested change

if *is_permissionless {

*is_permissionless = false

}

if *is_permissionless {

*is_permissionless = false;

}

greptile-apps · 2025-07-30T09:43:29Z

crates/pinocchio/world/src/instructions/remove_authority.rs

+    if !authorities.contains(authority_to_delete.key()) {
+        return Err(WorldError::InvalidAuthority.into());
+    }


logic: Missing authority validation - should verify that the calling authority has permission to remove other authorities from the world

greptile-apps · 2025-07-30T09:43:40Z

crates/pinocchio/cpi-interface/src/component/update.rs

+            AccountMeta::readonly(self.instruction_sysvar_account.key()),
+        ];
+
+        const DISCRIMATOR_LENGTH: usize = 8;


syntax: Typo: 'DISCRIMATOR_LENGTH' should be 'DISCRIMINATOR_LENGTH'

Suggested change

const DISCRIMATOR_LENGTH: usize = 8;

const DISCRIMINATOR_LENGTH: usize = 8;

greptile-apps · 2025-07-30T09:43:41Z

crates/pinocchio/world/src/utils.rs

@@ -0,0 +1,70 @@
+use crate::consts::DISCRIMATOR_LENGTH;


syntax: Typo in constant name: 'DISCRIMATOR_LENGTH' should be 'DISCRIMINATOR_LENGTH'

Suggested change

use crate::consts::DISCRIMATOR_LENGTH;

use crate::consts::DISCRIMINATOR_LENGTH;

greptile-apps · 2025-07-30T09:43:41Z

crates/pinocchio/world/src/instructions/apply_system.rs

+    }
+    .invoke()?;
+
+    let return_data = get_return_data().ok_or(ProgramError::InvalidAccountData)?;


logic: Return data validation only checks for existence, not minimum size. If system returns malformed data with less than 4 bytes, the subsequent parsing will fail.

greptile-apps · 2025-07-30T09:43:43Z

crates/pinocchio/world/src/instructions/add_authority.rs

+        return Err(ProgramError::MissingRequiredSignature);
+    }
+
+    let world_id = u64::from_le_bytes(unsafe { (data.as_ptr() as *const [u8; 8]).read() });


logic: Unsafe pointer casting without length validation could cause memory safety issues if data is shorter than 8 bytes

Suggested change

let world_id = u64::from_le_bytes(unsafe { (data.as_ptr() as *const [u8; 8]).read() });

let world_id = u64::from_le_bytes(

data.get(..8)

.ok_or(ProgramError::InvalidInstructionData)?

.try_into()

.map_err(|_| ProgramError::InvalidInstructionData)?

);

greptile-apps · 2025-07-30T09:43:47Z

crates/pinocchio/cpi-interface/src/system/execute.rs

+
+        let mut instruction_data = [0u8; 1024];
+
+        const DISCRIMATOR_LENGTH: usize = 8;


syntax: Typo in constant name: 'DISCRIMATOR_LENGTH' should be 'DISCRIMINATOR_LENGTH' to match standard spelling

Suggested change

const DISCRIMATOR_LENGTH: usize = 8;

const DISCRIMINATOR_LENGTH: usize = 8;

notdanilo · 2025-09-11T16:48:21Z

How are you testing it? bolt test is running the previous world program.

pinocchio world

65d9a09

GabrielePicco marked this pull request as ready for review July 30, 2025 09:42

GabrielePicco changed the title ~~pinocchio world~~ Reimplementation of the world program with Pinocchio Jul 30, 2025

greptile-apps bot reviewed Jul 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reimplementation of the world program with Pinocchio #177

Reimplementation of the world program with Pinocchio #177

Uh oh!

thewuhxyz commented May 13, 2025 •

edited by GabrielePicco

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

greptile-apps bot Jul 30, 2025

Uh oh!

notdanilo commented Sep 11, 2025

Uh oh!

Uh oh!

		pub const ADD_AUTHORIITY_DISCRIMINATOR: u64 = 13217455069452700133;
		pub const REMOVE_AUTHORIITY_DISCRIMINATOR: u64 = 15585545156648003826;

	InitilizeComponent = INITIALIZE_COMPONENT_DISCRIMINATOR,
	InitializeComponent = INITIALIZE_COMPONENT_DISCRIMINATOR,

	pub const DISCRIMATOR_LENGTH: usize = 8;
	pub const DISCRIMINATOR_LENGTH: usize = 8;

	const DISCRIMATOR_LENGTH: usize = 8;
	const DISCRIMINATOR_LENGTH: usize = 8;

	use crate::consts::DISCRIMATOR_LENGTH;
	use crate::consts::DISCRIMINATOR_LENGTH;

-    let world_id = u64::from_le_bytes(unsafe { (data.as_ptr() as *const [u8; 8]).read() });
+    let world_id = u64::from_le_bytes(
+        data.get(..8)
+            .ok_or(ProgramError::InvalidInstructionData)?
+            .try_into()
+            .map_err(|_| ProgramError::InvalidInstructionData)?
+    );


		let mut instruction_data = [0u8; 1024];

		const DISCRIMATOR_LENGTH: usize = 8;

Reimplementation of the world program with Pinocchio #177

Are you sure you want to change the base?

Reimplementation of the world program with Pinocchio #177

Uh oh!

Conversation

thewuhxyz commented May 13, 2025 • edited by GabrielePicco Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Before & After Screenshots

Deploy Notes

Greptile Summary

Confidence score: 1/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

notdanilo commented Sep 11, 2025

Uh oh!

Uh oh!

thewuhxyz commented May 13, 2025 •

edited by GabrielePicco

Loading