Skip to content

fix: missing early return in validateMultiTrackState, division by zero in frame-export, stale closure in useFontManager - #1681

Open
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/reframe-batch-2
Open

fix: missing early return in validateMultiTrackState, division by zero in frame-export, stale closure in useFontManager#1681
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/reframe-batch-2

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Real fixes:

  1. timeline.ts: validateMultiTrackState continues past type check - TypeError when timelineTracks is not array
  2. frame-export.ts: captureFrameAsPng has no guard for 0-dimension video - divide by zero, NaN scale
  3. useFontManager.ts: stale closure in addFonts allows duplicate font entries on concurrent calls

…o in frame-export, stale closure in useFontManager
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix labels Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @saurabhhhcodes

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant