Skip to content

fix: variable shadowing prevents log event listener cleanup#1674

Open
saurabhhhcodes wants to merge 2 commits into
magic-peach:mainfrom
saurabhhhcodes:fix/leaked-log-event-listener
Open

fix: variable shadowing prevents log event listener cleanup#1674
saurabhhhcodes wants to merge 2 commits into
magic-peach:mainfrom
saurabhhhcodes:fix/leaked-log-event-listener

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

The logListener variable was declared with const inside the try block, shadowing the outer let declaration. The finally block tried to clean up the outer (null) variable, never removing the listener. This caused listeners to accumulate on repeated exports, leading to memory growth.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @saurabhhhcodes

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:refactor Code refactor labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant