Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted package.json version of Gomage #4392

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Reverted package.json version of Gomage #4392

merged 1 commit into from
Feb 6, 2025

Conversation

del22123
Copy link
Collaborator

@del22123 del22123 commented Feb 6, 2025

Description

Updated the GoMage version from 0.0.1 to 3.94.0

Closes #PWA-2968
https://jira.corp.adobe.com/browse/PWA-2968

Acceptance

correct version should be there

Verification Stakeholders

team

Specification

Verification Steps

just check the version in dev branch if same or not

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 7d5808c

glo42707
glo42707 previously approved these changes Feb 6, 2025
@glo42707 glo42707 added the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Feb 6, 2025
glo80684
glo80684 previously approved these changes Feb 6, 2025
@glo42707
Copy link
Contributor

glo42707 commented Feb 6, 2025

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 6, 2025

Successfully started codebuild job for pr-test

@glo42707
Copy link
Contributor

glo42707 commented Feb 6, 2025

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 6, 2025

Successfully started codebuild job for pr-deploy

@glo42707 glo42707 removed the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Feb 6, 2025
@glo82145 glo82145 changed the base branch from release/14.2.0 to develop February 6, 2025 07:08
@glo82145 glo82145 dismissed stale reviews from glo80684 and glo42707 February 6, 2025 07:08

The base branch was changed.

@glo82145 glo82145 merged commit 02fbe2e into develop Feb 6, 2025
4 of 8 checks passed
@glo82145 glo82145 deleted the PWA-2968-V3 branch February 6, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants