Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Separate out app shell into its own bundle. #1783

Open
7 tasks
revanth0212 opened this issue Sep 25, 2019 · 2 comments
Open
7 tasks

[feature]: Separate out app shell into its own bundle. #1783

revanth0212 opened this issue Sep 25, 2019 · 2 comments
Labels
enhancement New feature or request performance Things related to perf Progress: ready for grooming

Comments

@revanth0212
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Related to #1673

Describe the solution you'd like
The app shell is the parent for the whole app content. Any page we go to, the app shell stays the same. Separating it out into its own bundle, we can request it once and then keep using it till something changes. That can be potential gains in terms of performance and offline functionality as well.

image

image

image

image

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@revanth0212 revanth0212 added the enhancement New feature or request label Sep 25, 2019
@revanth0212 revanth0212 mentioned this issue Sep 27, 2019
Open
8 tasks
@revanth0212 revanth0212 added the performance Things related to perf label Sep 30, 2019
@cherdman
Copy link
Contributor

https://jira.corp.magento.com/browse/PWA-70

@revanth0212
Copy link
Contributor Author

Moving it out of Performance Milestone for now. Should revisit this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance Things related to perf Progress: ready for grooming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sirugh @revanth0212 @cherdman