Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Module based chunking along with route based chunking. #1804

Open
4 of 8 tasks
revanth0212 opened this issue Sep 27, 2019 · 5 comments
Open
4 of 8 tasks

[feature]: Module based chunking along with route based chunking. #1804

revanth0212 opened this issue Sep 27, 2019 · 5 comments
Labels
enhancement New feature or request performance Things related to perf Progress: ready for grooming

Comments

@revanth0212
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Related to #1673 #1765 #1783

Describe the solution you'd like
We can chunk the app based on its availability requirement in the app. For instance, the left drawer is needed in all the pages. We can separate out the left drawer or combine that with app shell and sever it as a bundle of its own so it should be cached on the UI and reused until something changes. Also, we can server render these bundles for better performance (if possible).

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@revanth0212 revanth0212 added the enhancement New feature or request label Sep 27, 2019
@revanth0212 revanth0212 added the performance Things related to perf label Sep 30, 2019
@revanth0212
Copy link
Contributor Author

This needs more research. Need to check on what Root Components Chunking is and how is that is related to what this issue addresses.

@supernova-at
Copy link
Contributor

#1765 introduced route-based code splitting.

Edit: Oh I see you've already linked it :P :)

@revanth0212
Copy link
Contributor Author

#1765 introduced route-based code splitting.

Yeah, this adds chunking on top of what #1765 offers. #1765 already gives us a boost with a smaller client.js which can be broken up into even smaller chunks using module-based chunking.

@cherdman
Copy link
Contributor

@revanth0212
Copy link
Contributor Author

This has a high workload. Removing from the Performance Milestone for now. Will revisit in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Things related to perf Progress: ready for grooming
Projects
None yet
Development

No branches or pull requests

4 participants