-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #40143 - Only X left in stock for configurable product #40144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @thomas-kl1. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
The fix here is still relevant. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @thomas-kl1,
Thanks for the contribution!
The failed tests doesn't related to this PR, but I guess we can add some automated test for the below scenarios:
- Configurable with No Variants - Test null coalescing operator
- Simple Product Regression - Ensure unchanged behavior
- Basic Stock Threshold Logic - Core functionality works
Description (*)
Fix the original desired behavior and fetch the first variant of a configurable product.
Manual testing scenarios (*)
Expected: only_x_left_in_stock is the value of its first variant
Result: Error
Questions or comments
Not sure that's the best way to fix it, IMO it should be done on MSI side.
Contribution checklist (*)