Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Flush Magento Cache" button should be renamed "Clean Magento Cache" #39724

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/Block/Cache.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ protected function _construct()
$this->buttonList->add(
'flush_magento',
[
'label' => __('Flush Magento Cache'),
'label' => __('Clean Magento Cache'),
'onclick' => 'setLocation(\'' . $this->getFlushSystemUrl() . '\')',
'class' => 'primary flush-cache-magento'
]
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/etc/acl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<resource id="Magento_Backend::cache" title="Cache Management" translate="title" sortOrder="10">
<resource id="Magento_Backend::main_actions" title="Clean Cache Actions" translate="title" sortOrder="10">
<resource id="Magento_Backend::flush_cache_storage" title="Flush Cache Storage" translate="title" sortOrder="10" />
<resource id="Magento_Backend::flush_magento_cache" title="Flush Magento Cache" translate="title" sortOrder="20" />
<resource id="Magento_Backend::flush_magento_cache" title="Clean Magento Cache" translate="title" sortOrder="20" />
</resource>
<resource id="Magento_Backend::mass_actions" title="Cache Types Management" translate="title" sortOrder="20">
<resource id="Magento_Backend::toggling_cache_type" title="Toggle Cache Type" translate="title" sortOrder="10" />
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Cache Storage Management","Cache Storage Management"
"Flush Magento Cache","Flush Magento Cache"
"The cache storage may contain additional data. Are you sure that you want to flush it?","The cache storage may contain additional data. Are you sure that you want to flush it?"
"Flush Cache Storage","Flush Cache Storage"
"Clean Cache Storage","Clean Cache Storage"
Invalidated,Invalidated
Orders,Orders
Amounts,Amounts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="ClearCacheActionGroup">
<annotations>
<description>Goes to the Admin Cache Management page. Clicks on 'Flush Magento Cache'.</description>
<description>Goes to the Admin Cache Management page. Clicks on 'Clean Magento Cache'.</description>
</annotations>

<amOnPage url="{{AdminCacheManagementPage.url}}" stepKey="goToCacheManagement"/>
Expand Down