Skip to content

39707 [GraphQl] Route query infinite loop #39708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from
Open

39707 [GraphQl] Route query infinite loop #39708

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbae2c8
39707: Added check to determind should it find final URL or not
rybkinevg Mar 5, 2025
52c0e47
Merge branch '2.4-develop' into 39707-graph-ql-route-query-infinite-loop
rybkinevg Mar 19, 2025
9e86dae
Merge branch '2.4-develop' into 39707-graph-ql-route-query-infinite-loop
rybkinevg Mar 30, 2025
5484d14
Merge branch '2.4-develop' into 39707-graph-ql-route-query-infinite-loop
rybkinevg Apr 8, 2025
5e512d3
Merge branch '2.4-develop' into 39707-graph-ql-route-query-infinite-loop
rybkinevg Apr 14, 2025
2ded310
39707: Updated copyright (fix static test)
rybkinevg Apr 14, 2025
2710d68
Merge branch '2.4-develop' into 39707-graph-ql-route-query-infinite-loop
rybkinevg Apr 16, 2025
9cf76cf
39707: Added slash trimming
rybkinevg Apr 16, 2025
e67100e
39707: Added condition to break loop when target paths are the same
rybkinevg Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/code/Magento/UrlRewriteGraphQl/Model/Resolver/AbstractEntityUrl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2025 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);

Expand Down Expand Up @@ -136,6 +136,11 @@ private function findFinalUrl(UrlRewrite $urlRewrite): UrlRewrite
$urlRewrite->getTargetPath(),
(int) $urlRewrite->getStoreId()
);

if ($nextUrlRewrite?->getTargetPath() === $urlRewrite->getTargetPath()) {
return $nextUrlRewrite;
}

if ($nextUrlRewrite) {
$urlRewrite = $nextUrlRewrite;
}
Expand Down