magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

KrasnoshchokBohdan · 2025-03-01T11:13:24Z

Description (*)

As the author of the issue mentioned, if we add a special price using POST /rest/<store_code>/V1/products/special-price specifying in the request body date like "price_to": "2017-07-16 23:59:59" i.e. time including hours, minutes and seconds, then as a result we will get that the special price will be valid for one day longer than the specified date

this happens in the method \Magento\Framework\Stdlib\DateTime\Timezone::isScopeDateInInterval where there is code that literally adds +1 day

      if ($dateTo) {
            // fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
            $toTimeStamp += 86400;
        }

according to the example from the documentation (where "price_to": "2017-07-16 23:59:59" including hours is specified) we get this execution

therefore in this pull request I propose to skip adding 1 day in case in "price_to" specifies the time including hours

Related Pull Requests

--

Fixed Issues (if relevant)

Fixes Special Price To Date is wrongly validated on applySpecialPrice #39169

Manual testing scenarios (*)

add special price to product by POST /rest/<store_code>/V1/products/special-price according documentation
check product price, it will have special price one day longer

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…cialPrice

m2-assistant · 2025-03-01T11:13:27Z

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

KrasnoshchokBohdan · 2025-03-01T11:13:52Z

@magento run all tests

engcom-Hotel · 2025-03-28T05:00:38Z

@magento run all tests

engcom-Hotel

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

Please fix the failed static test and also please add an automated test in accordance to the DOD.

Thanks

…cialPrice - changing Copyright

KrasnoshchokBohdan · 2025-04-02T12:00:41Z

@magento run all tests

engcom-Hotel

Hello @KrasnoshchokBohdan,

Please also add some automated tests.

Thanks

Den4ik · 2025-04-07T21:23:55Z

lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

@@ -274,7 +274,7 @@ public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
        $scopeTimeStamp = $this->scopeTimeStamp($scope);
        $fromTimeStamp = strtotime($dateFrom);
        $toTimeStamp = strtotime($dateTo);
-        if ($dateTo) {
+        if ($dateTo && date('H:i:s', strtotime($dateTo)) === '00:00:00') {


We will have the same +1 day result if use '00:00:00' in the API query. I'm not sure that it's correct solution

KrasnoshchokBohdan · 2025-04-09T08:59:37Z

@Den4ik

We will have the same +1 day result if use '00:00:00' in the API query. I'm not sure that it's correct solution

pls provide more information

if we update special price with
"price_to": "2025-07-18 00:00:00" we get "2025-07-18 23:59:59" and this is ok by my view
but if we update with
"price_to": "2025-07-18 17:00:00" we get "2025-07-19 17:00:00" before fix
and "2025-07-18 17:00:00" after

your special price will be visible until tomorrow 17
so instead expire at 2024-09-12 17:00:00 it will expire on 2024-09-13 17:00:00

#39169 from description

how I tested it

https://app.magento.test/rest/default/V1/products/special-price (app.magento.test replace with your base_url)
body
{
"prices": [
{
"price": 100,
"store_id": 0,
"price_from": "2025-04-08 00:00:00",
"price_to": "2025-07-18 17:00:00",
"sku": "test-simple" // your sku
}
]
}
(date price_from should be not in future)

if we check with POST /rest/<store_code>/V1/products/special-price-information
or in catalog_product_entity_datetime price_to date will be the same as in body (for example "2025-07-18 17:00:00")

but we should triger \Magento\Framework\Stdlib\DateTime\Timezone::isScopeDateInInterval
for this I'm using pdp page (with clean cache)

before fix

after fix

Den4ik · 2025-04-09T09:10:37Z

@KrasnoshchokBohdan I mean +86400 will add 24h to the request date.

"price_to": "2025-07-18 00:00:00" we get "2025-07-18 23:59:59" and this is ok by my view

After the fix "price_to": "2025-07-18 00:00:00" will be "price_to": "2025-07-19 00:00:00"

I haven't checked the source code more deeply, but I don't rule out that somewhere the time value may be thrown off and date become 2025-07-19

KrasnoshchokBohdan · 2025-04-09T09:29:17Z

After the fix "price_to": "2025-07-18 00:00:00" will be "price_to": "2025-07-19 00:00:00"

but it was the same before fix

fix is only cover

your special price will be visible until tomorrow 17
so instead expire at 2024-09-12 17:00:00 it will expire on 2024-09-13 17:00:00

#39169 from description

{
"prices": [
{
"price": 100,
"store_id": 0,
"price_from": "2025-04-08 00:00:00",
"price_to": "2025-07-18 00:00:00",
"sku": "test-simple"
}
]
}

no changes

after fix

sorry it seems I still don't understand the question

KrasnoshchokBohdan · 2025-04-09T10:02:28Z

@Den4ik

I haven't checked the source code more deeply, but I don't rule out that somewhere the time value may be thrown off and date become 2025-07-19

maybe you meen - date become 2025-07-17?
because, according to documentations

https://experienceleague.adobe.com/en/docs/commerce-admin/catalog/products/pricing/product-price-special

The special price goes into effect immediately after midnight at the beginning of the start date (00:01) and continues until just before midnight (23:59) on the day before the end date.

and I dont see any manipulation with special price date except the method we looking
\Magento\Catalog\Pricing\Price\SpecialPrice::getValue

so maybe I should replace

// fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
            $toTimeStamp += 86400;

to

// fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
            $toTimeStamp -= 1;

…cialPrice - added unit tests

KrasnoshchokBohdan · 2025-04-10T07:41:23Z

@magento run all tests

Den4ik · 2025-04-10T08:19:26Z

@KrasnoshchokBohdan Thanks for your comment. Let me check code, but based on comment // fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59 from previous solution

if ($dateTo && date('H:i:s', strtotime($dateTo)) === '00:00:00') {
    // fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
     $toTimeStamp += 86399;
}

will provide expected 23:59:59

magento#39169: Special Price To Date is wrongly validated on applySpe…

9111182

…cialPrice

m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Mar 1, 2025

Merge branch '2.4-develop' into fix-for-issue-39169

364b4e5

engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Mar 3, 2025

Priyakshic added the Project: Community Picked PRs upvoted by the community label Mar 13, 2025

Priyakshic added this to Community Dashboard Mar 13, 2025

Priyakshic moved this to Pending Review in Community Dashboard Mar 13, 2025

engcom-Hotel self-requested a review March 28, 2025 05:00

Merge branch '2.4-develop' into fix-for-issue-39169

2a9dec5

engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Mar 28, 2025

engcom-Hotel added the Progress: review label Mar 28, 2025

engcom-Hotel requested changes Apr 1, 2025

View reviewed changes

engcom-Hotel added Progress: needs update and removed Progress: review labels Apr 1, 2025

engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Apr 1, 2025

engcom-Charlie self-assigned this Apr 1, 2025

magento#39169: Special Price To Date is wrongly validated on applySpe…

131815c

…cialPrice - changing Copyright

engcom-Hotel requested changes Apr 3, 2025

View reviewed changes

Den4ik requested changes Apr 7, 2025

View reviewed changes

KrasnoshchokBohdan and others added 2 commits April 10, 2025 10:38

magento#39169: Special Price To Date is wrongly validated on applySpe…

0d8b6b0

…cialPrice - added unit tests

Merge branch '2.4-develop' into fix-for-issue-39169

c8c8b35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

KrasnoshchokBohdan commented Mar 1, 2025

m2-assistant bot commented Mar 1, 2025

KrasnoshchokBohdan commented Mar 1, 2025

engcom-Hotel commented Mar 28, 2025

engcom-Hotel left a comment

KrasnoshchokBohdan commented Apr 2, 2025

engcom-Hotel left a comment

Den4ik Apr 7, 2025

KrasnoshchokBohdan commented Apr 9, 2025

Den4ik commented Apr 9, 2025 •

edited

Loading

KrasnoshchokBohdan commented Apr 9, 2025 •

edited

Loading

KrasnoshchokBohdan commented Apr 9, 2025

KrasnoshchokBohdan commented Apr 10, 2025

Den4ik commented Apr 10, 2025 •

edited

Loading

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

Are you sure you want to change the base?

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

Conversation

KrasnoshchokBohdan commented Mar 1, 2025

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Mar 1, 2025

KrasnoshchokBohdan commented Mar 1, 2025

engcom-Hotel commented Mar 28, 2025

engcom-Hotel left a comment

Choose a reason for hiding this comment

KrasnoshchokBohdan commented Apr 2, 2025

engcom-Hotel left a comment

Choose a reason for hiding this comment

Den4ik Apr 7, 2025

Choose a reason for hiding this comment

KrasnoshchokBohdan commented Apr 9, 2025

Den4ik commented Apr 9, 2025 • edited Loading

KrasnoshchokBohdan commented Apr 9, 2025 • edited Loading

KrasnoshchokBohdan commented Apr 9, 2025

KrasnoshchokBohdan commented Apr 10, 2025

Den4ik commented Apr 10, 2025 • edited Loading

Den4ik commented Apr 9, 2025 •

edited

Loading

KrasnoshchokBohdan commented Apr 9, 2025 •

edited

Loading

Den4ik commented Apr 10, 2025 •

edited

Loading