Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #39530 to avoid regenerating admin grid flat table #39540

Open
wants to merge 13 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

senthilengg
Copy link

Updating indexer state hash upon creation of new encryption key from admin

Description (*)

Fixed Issues

  1. Fixes @engcom-Hotel Reproduced #39206 issue in 2.4.7-p1 #39530

Manual testing scenarios (*)

  1. Go to index management and note down the updated time
  2. Change Encryption Key from Admin
  3. Go to index management and ensure all of the rows with same update time or similar
  4. Run setup upgrade. Should not update the indexer state table again

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Updating indexer state hash upon creation of new encryption key from admin
Copy link

m2-assistant bot commented Jan 14, 2025

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@senthilengg senthilengg reopened this Jan 14, 2025
@senthilengg
Copy link
Author

@magento run all tests

Adding Indexer Dependency to make the static test build pass
@senthilengg
Copy link
Author

@magento run Static Tests

@senthilengg
Copy link
Author

@magento run Static Tests

@senthilengg
Copy link
Author

@magento run all tests

@senthilengg
Copy link
Author

@magento run Semantic Version Checker

Copy link
Member

@tuyennn tuyennn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senthilengg The prerequisite for pull requests to be accepted is compliance with PSR-1 and PSR-2 standards, as outlined here: Adobe PHP Coding Standards.

Since you appear to be using PSR-12 compliance, the first step is to adjust your code to align with PSR-1 and PSR-2 standards.

@senthilengg
Copy link
Author

@tuyennn My change is only on one single file and the associated unit test. Are you saying I had to fix the entire module to submit a PR for an issue that I would like to fix ?

@tuyennn
Copy link
Member

tuyennn commented Jan 17, 2025

@senthilengg apperally I think so. Entire your pull request

@senthilengg
Copy link
Author

@magento run all tests

@senthilengg senthilengg requested a review from tuyennn January 18, 2025 01:38
@senthilengg
Copy link
Author

The failed tests doesn’t seems to be because of this PR, hence requesting to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@engcom-Hotel Reproduced #39206 issue in 2.4.7-p1
2 participants