-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #39530 to avoid regenerating admin grid flat table #39540
base: 2.4-develop
Are you sure you want to change the base?
Fix for issue #39530 to avoid regenerating admin grid flat table #39540
Conversation
Updating indexer state hash upon creation of new encryption key from admin
Hi @senthilengg. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Adding Indexer Dependency to make the static test build pass
@magento run Static Tests |
@magento run Static Tests |
@magento run all tests |
@magento run Semantic Version Checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senthilengg The prerequisite for pull requests to be accepted is compliance with PSR-1 and PSR-2 standards, as outlined here: Adobe PHP Coding Standards.
Since you appear to be using PSR-12 compliance, the first step is to adjust your code to align with PSR-1 and PSR-2 standards.
@tuyennn My change is only on one single file and the associated unit test. Are you saying I had to fix the entire module to submit a PR for an issue that I would like to fix ? |
@senthilengg apperally I think so. Entire your pull request |
@magento run all tests |
The failed tests doesn’t seems to be because of this PR, hence requesting to review |
Updating indexer state hash upon creation of new encryption key from admin
Description (*)
Fixed Issues
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)