-
Notifications
You must be signed in to change notification settings - Fork 9.4k
remove image style and script coming next to it. #37720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @Sahilsks. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Hi @Sahilsks, Thank you reporting and collaboration. Please provide proper description and steps to reproduce the issue to proceed further. Thanks. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@@ -12,7 +12,7 @@ $width = (int)$block->getWidth(); | |||
$paddingBottom = $block->getRatio() * 100; | |||
?> | |||
<span class="product-image-container product-image-container-<?= /* @noEscape */ $block->getProductId() ?>"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need this ID any more given the other changes in this pull request.
<span class="product-image-container product-image-container-<?= /* @noEscape */ $block->getProductId() ?>"> | |
<span class="product-image-container"> |
@@ -12,7 +12,7 @@ $width = (int)$block->getWidth(); | |||
$paddingBottom = $block->getRatio() * 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need these two variables ($width
, $paddingBottom
) any more given the other changes in this pull request. (GitHub won't let me comment on line 11, so the suggestion here is incomplete.)
$paddingBottom = $block->getRatio() * 100; |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)