Shorter RegExp for trim polyfill. Fixes #617

madrobby · Mar 3, 2013 · 3771d17 · 3771d17
1 parent 2efb3fb
commit 3771d17
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/polyfill.js b/src/polyfill.js
@@ -4,7 +4,7 @@
 
 ;(function(undefined){
   if (String.prototype.trim === undefined) // fix for iOS 3.2
-    String.prototype.trim = function(){ return this.replace(/^\s+/, '').replace(/\s+$/, '') }
+    String.prototype.trim = function(){ return this.replace(/^\s+|\s+$/g, '') }
 
   // For iOS 3.x
   // from https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/reduce

diff --git a/test/polyfill.html b/test/polyfill.html
@@ -23,6 +23,7 @@ <h1>Compatibility tests</h1>
       // test to see if we augment String.prototype.trim if not supported natively
       testTrim: function(t){
         t.assertEqual("blah", " blah ".trim())
+        t.assertEqual("bl \n ah", " bl \n ah ".trim())
       },
 
       // test to see if we augment Array.prototype.reduceif not supported natively