Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double checks in preprocessing and runtime #1053

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove double checks in preprocessing and runtime #1053

wants to merge 1 commit into from

Conversation

irwir
Copy link

@irwir irwir commented Feb 27, 2025

No description provided.

@madler
Copy link
Owner

madler commented Feb 27, 2025

Please provide a short description and rationale for the changes. Thanks.

@irwir
Copy link
Author

irwir commented Feb 27, 2025 •
edited
Loading

Conditions zi->ci.method == Z_DEFLATED in line 1421 was rechecked in 1424.
Similarly, for zi->ci.method == Z_BZIP2ED.
Fewer conditional compilation directives; overall the code gets shorter and clearer.

Reason for removed pointer operation is in the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irwir @madler