Skip to content

chore: update#6

Merged
madkoo merged 6 commits into
mainfrom
npm-publish
Mar 18, 2026
Merged

chore: update#6
madkoo merged 6 commits into
mainfrom
npm-publish

Conversation

@madkoo

@madkoo madkoo commented Mar 18, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 13:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release GitHub Actions workflow to add extra safety checks around tag releases and adjusts npm publishing behavior.

Changes:

  • Fetch full git history and verify the tag’s commit exists on main before releasing.
  • Verify package.json version matches the pushed tag name.
  • Change npm publish command from npm publish --access public to npm publish.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
madkoo and others added 2 commits March 18, 2026 16:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 18, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the npm release workflow by adding pre-publish validation checks to prevent releasing tags that aren’t based on main and to ensure the git tag matches package.json’s version.

Changes:

  • Fetch full git history in the release job to enable ancestry checks.
  • Add a step to verify the tag’s commit exists on main.
  • Add a step to verify package.json version matches the pushed tag, and simplify npm publish invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Copilot AI review requested due to automatic review settings March 18, 2026 14:43
@madkoo madkoo merged commit dce8733 into main Mar 18, 2026
8 checks passed
@madkoo madkoo deleted the npm-publish branch March 18, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflows to tighten release safety checks and move the project’s CI/release runtime forward to newer Node.js versions.

Changes:

  • Add release-time guards to ensure the tag commit is reachable from main and that the git tag matches package.json version.
  • Bump Node.js used in release workflow to 24 and CI matrix to [20, 22, 24].
  • Simplify npm publish command in the release workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/release.yml Adds tag/version verification steps; updates Node version; tweaks publish invocation.
.github/workflows/ci.yml Updates the Node.js test matrix versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
strategy:
matrix:
node-version: [18, 20, 22]
node-version: [20, 22, 24]
uses: actions/setup-node@v6
with:
node-version: '20'
node-version: '24'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants