Update dependencies#16
Merged
Merged
Conversation
npm audit fix: vite 8.0.1→8.0.8, picomatch 4.0.3→4.0.4 (vitest tree). Resolves 6 of 7 dependabot alerts (3 high, 2 medium, 1 auto-dismissed). Remaining: picomatch 2.3.1 via fast-glob→micromatch (awaiting upstream fix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Install @biomejs/biome as devDependency with biome.json config (2-space indent, single quotes, recommended rules, import sorting) - Add lint, lint:fix, and format npm scripts targeting src/ and tests/ - Auto-fix all existing violations: node: protocol imports, import type, import sorting, forEach callback returns in tests - Add Lint step to CI workflow before Build - Update copilot-instructions.md with new lint commands All 50 tests pass, build clean, zero lint violations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The function was flagged by Biome as unused (underscore prefix convention). Removed the function and its os import; kept tmpDirs cleanup used by other tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates project dependencies and tooling configuration, mainly to modernize Node/TypeScript usage and enforce consistent formatting/linting in CI for the dfiles CLI codebase.
Changes:
- Bump dev dependencies (notably TypeScript) and add Biome with new lint/format npm scripts.
- Migrate Node built-in imports to the
node:specifier and apply formatting adjustments across src/tests. - Add Biome config, wire lint step into GitHub Actions CI, and introduce Copilot repo instructions.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/sync.test.ts | Switch to node: imports + reformat test calls. |
| tests/status.test.ts | Switch to node: imports + reformat helper/types usage. |
| tests/cache.test.ts | Switch to node: imports + formatting changes in assertions/hooks. |
| src/sync.ts | Use node: imports and import type, minor signature/error formatting tweaks. |
| src/index.ts | Import order/formatting adjustments for CLI wiring. |
| src/config.ts | Use node: imports and import type, minor error formatting tweaks. |
| src/commands/status.ts | Use node: imports and simplify row formatting. |
| src/commands/pull.ts | Use import type and reformat output/width calculations. |
| src/commands/list.ts | Simplify row formatting implementation. |
| src/commands/init.ts | Use node: imports and import type. |
| src/commands/add.ts | Use node: imports and import type, formatting tweaks. |
| src/cache.ts | Use node: imports, minor error formatting tweaks. |
| package.json | Version bump, add Biome scripts, update dev deps. |
| package-lock.json | Lockfile updated for new dev deps (notably Biome/TypeScript). |
| biome.json | New Biome configuration. |
| .github/workflows/ci.yml | Add npm run lint step to CI. |
| .github/copilot-instructions.md | New repo-specific Copilot guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "@madkoo/dfiles", | ||
| "version": "1.1.1", | ||
| "version": "1.1.2", |
Comment on lines
+27
to
31
| "@biomejs/biome": "^2.4.12", | ||
| "@types/node": "^25.5.0", | ||
| "ts-node": "^10.9.0", | ||
| "typescript": "^5.4.0", | ||
| "typescript": "^6.0.2", | ||
| "vitest": "^4.0.0" |
|
|
||
| ## Must follow workflow | ||
|
|
||
| 1. Always when implementing a feature or bug fix always create new tests and update exisiting ones as needed. Tests should cover both typical and edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.