Refactor retryJob function for better error handling - #84
Open
mspandey wants to merge 1 commit into
Open
Conversation
# Improve Retry Job Error Handling ## Summary We changed the retry job functionality to properly handle failed API responses when retrying screenshot processing jobs. ## Changes * Added response status validation to the retry request. * Throw an error when the retry endpoint returns a non-success status code. * Prevent silent failures during job retry operations. * Improve reliability of queue management actions. ## Why Previously, the retry request only awaited the fetch call and did not verify whether the server actually accepted the retry request. This meant failed requests could appear successful from the user's perspective, leading to confusing behavior and making troubleshooting more difficult. By validating the response status, retry failures can now be surfaced and handled correctly. ## Impact * Improves reliability of retry operations. * Prevents silent API failures. * Makes debugging easier when queue retries fail. * Provides a stronger foundation for future user-facing error messages and notifications.
|
🎉 Thanks for submitting a PR, @mspandey! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
@mspandey ESOC or SSOC ? and please read contribution guidlines |
Author
|
Esoc
…On Fri, 19 Jun 2026, 1:51 pm Madhav Majumdar, ***@***.***> wrote:
*madhav2348* left a comment (madhav2348/ss_ai#84)
<#84 (comment)>
@mspandey <https://github.com/mspandey> ESOC or SSOC ? and please read
contribution guidlines
—
Reply to this email directly, view it on GitHub
<#84?email_source=notifications&email_token=BWCE2HH6QJPUHUKKJWJGPHL5ATZZHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUHE3TSMRXGEZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4749792712>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWCE2HAQGMCJTV4XRDNM3GT5ATZZHAVCNFSNUABGKJSXA33TNF2G64TZHMYTCNZYGY3TQOJTGM5US43TOVSTWNBWHE4DSNJQGE3DTILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BWCE2HAVPQVIWA3C4T7UFAT5ATZZHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUHE3TSMRXGEZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BWCE2HA2DMGGZ7ZOQZ4SAAL5ATZZHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUHE3TSMRXGEZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add state parameter to OAuth flow for validationconst ## Summary
Add OAuth state validation to the Google authentication flow.
Changes Made
stateparameter before initiating Google sign-in.Why This Change?
The current Google OAuth implementation does not include a
stateparameter. Without state validation, the application is more vulnerable to CSRF and authorization response spoofing attacks.Adding state verification aligns the authentication flow with OAuth 2.0 security best practices and improves protection against malicious or unexpected authorization responses.
Impact