Remove unused screenshot data insertion code - #79
Open
mspandey wants to merge 1 commit into
Open
Conversation
Removed unused code for running a statement with screenshot data.## Summary Fix repository consistency around screenshot file hash handling. ## Changes Made * Updated screenshot repository logic to properly handle file hash storage and retrieval. * Ensured repository implementation remains consistent with screenshot type definitions and database schema. * Resolved mismatch between persisted database fields and screenshot model properties. ## Why This Change? The repository schema and query methods support file hash operations (`file_hash`, `findByHash()`), but the screenshot data model does not consistently expose or manage hash information. This creates a disconnect between the application layer and persistence layer, making hash-based lookups unreliable and potentially causing type inconsistencies. This change aligns the repository implementation with the underlying data model and database structure. ## Impact * Improves consistency between types, repository logic, and database schema. * Enables reliable hash-based record lookup. * Reduces potential runtime and type-related issues. * Makes future deduplication and file integrity features easier to implement.
|
🎉 Thanks for submitting a PR, @mspandey! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
ESOC or SSOC ? and please read contribution guidlines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused code for running a statement with screenshot data.## Summary
Fix repository consistency around screenshot file hash handling.
Changes Made
Why This Change?
The repository schema and query methods support file hash operations (
file_hash,findByHash()), but the screenshot data model does not consistently expose or manage hash information. This creates a disconnect between the application layer and persistence layer, making hash-based lookups unreliable and potentially causing type inconsistencies.This change aligns the repository implementation with the underlying data model and database structure.
Impact
Summary: Describe your changes
Issue ticket number and link
Closes #
Changes
Testing
Checklist before requesting a review
.envvalues are committed