Change content type for XLSX export endpoint - #77
Open
mspandey wants to merge 1 commit into
Open
Conversation
## Summary Fix export response headers for the XLSX export endpoint. ## Changes Made * Updated the `/exports/xlsx` endpoint to return the correct MIME type for Excel files. * Added an appropriate download filename for exported spreadsheets. ## Why This Change? The endpoint is named `/exports/xlsx` and uses the `XlsxExporter`, but the response currently advertises the file as CSV content. This can cause incorrect file handling in browsers and spreadsheet applications. Using the correct XLSX content type ensures exported files are recognized and downloaded properly. ## Impact * Improves compatibility with spreadsheet software. * Ensures browsers handle exports correctly. * Aligns API behavior with endpoint naming and exporter implementation.
|
🎉 Thanks for submitting a PR, @mspandey! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
ESOC or SSOC ? and please read contribution guidlines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass job IDs from the queue worker to the screenshot pipeline to enable stage-level status tracking.
Changes Made
createQueueWorkerto pass the current job ID when invokingpipeline.process().Why This Change?
The screenshot pipeline already supports job-aware status updates through the optional
jobIdparameter. However, the queue worker was invoking the pipeline without providing the job ID, preventing intermediate stages such as OCR, Vision, Source Detection, and Tagging from being reflected in queue status updates.Passing the job ID allows the pipeline to report accurate progress throughout processing.
Impact