Refactor saveJson to use path.resolve and validate path - #74
Open
mspandey wants to merge 1 commit into
Open
Conversation
Update path handling in saveJson method to ensure safety.## Summary Prevent directory traversal when saving files to filesystem storage. ## Changes Made * Added validation to ensure generated file paths remain within the configured storage directory. * Replaced direct path joining with resolved path verification. ## Why This Change? The storage layer constructs file paths using a provided relative path. Without validation, specially crafted paths could potentially escape the intended storage directory and write files elsewhere on the filesystem. This change ensures all saved files remain inside the configured storage location. ## Impact * Improves filesystem safety. * Prevents potential directory traversal issues. * Maintains existing behavior for valid storage paths.
|
🎉 Thanks for submitting a PR, @mspandey! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
ESOC or SSOC ? and please read contribution guidlines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused
createQueueWorkerimport from bootstrap module.Changes Made
createQueueWorkerimport.Why This Change?
The
createQueueWorkersymbol was imported but never referenced within the module. This can trigger lint warnings and make the code harder to maintain by suggesting functionality that is not actually used.Impact