Chore/remove legacy api server - #106
Open
Vaibhavi410 wants to merge 9 commits into
Open
Conversation
…-page feat: add job history page with live tracking and details view
Co-authored-by: Laasya <m.laasya07@email.com>
|
🎉 Thanks for submitting a PR, @Vaibhavi410! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
Even it's not in use , that's not a good idea to remove, you could raise an issue before pushing PR @Vaibhavi410 , that's not best practices and you didn't follow the contribution guidelines |
Owner
|
Are you from ESOC |
Author
|
yes i'm from ESOC i'm extremely sorry for the incovinence but i have raised the issue before, i'll close the PR if that's the case |
Owner
According to esoc team close or mark invalid until coding period starts |
Author
|
ohh okayy i'll keep that in mind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Describe your changes
Deleted two old files that weren't being used by anything anymore.
Issue ticket number and link
Closes #105
Changes
Removed
src/server/server/api.tsandsrc/server/main.ts. These were an old server that did the same job as the routes already insrc/app/api/(health check, screenshots, exports) .Testing
Checklist before requesting a review
Code follows the project's TypeScript style conventions
No secrets or
.envvalues are committedI have performed a self-review of my code
CI passes