Skip to content

Chore/remove legacy api server - #106

Open
Vaibhavi410 wants to merge 9 commits into
madhav2348:mainfrom
Vaibhavi410:chore/remove-legacy-api-server
Open

Chore/remove legacy api server#106
Vaibhavi410 wants to merge 9 commits into
madhav2348:mainfrom
Vaibhavi410:chore/remove-legacy-api-server

Conversation

@Vaibhavi410

@Vaibhavi410 Vaibhavi410 commented Jun 22, 2026

Copy link
Copy Markdown

Summary: Describe your changes

Deleted two old files that weren't being used by anything anymore.

Issue ticket number and link

Closes #105

Changes

Removed src/server/server/api.ts and src/server/main.ts. These were an old server that did the same job as the routes already in src/app/api/ (health check, screenshots, exports) .

Testing

  • Added/updated tests (nothing new to test, I just deleted unused files)
  • Tested locally (describe steps)
    • Ran lint, type-check, and build both before and after deleting the files.
    • Same pre-existing warnings showed up either way (not caused by my change) actually one warning went away since it was specific to the file I deleted.
    • Build still works fine and all the real API routes show up correctly, so nothing in the app depends on the files I removed.
pr

Checklist before requesting a review

  • Code follows the project's TypeScript style conventions

  • No secrets or .env values are committed

  • I have performed a self-review of my code

  • CI passes

@github-actions

Copy link
Copy Markdown

🎉 Thanks for submitting a PR, @Vaibhavi410!

Please confirm the following checklist before review:

  • ⭐ I have starred this repository
  • 🍴 I have forked this repository
  • 📖 I have read the Contributing Guidelines
  • 🔀 My changes are pushed to the develop branch

A maintainer will review your PR shortly. Thank you! 🚀

@madhav2348

madhav2348 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Even it's not in use , that's not a good idea to remove, you could raise an issue before pushing PR @Vaibhavi410 , that's not best practices and you didn't follow the contribution guidelines

@madhav2348

Copy link
Copy Markdown
Owner

Are you from ESOC

@Vaibhavi410

Copy link
Copy Markdown
Author

yes i'm from ESOC i'm extremely sorry for the incovinence but i have raised the issue before, i'll close the PR if that's the case

@madhav2348 madhav2348 added the invalid This doesn't seem right label Jun 22, 2026
@madhav2348

Copy link
Copy Markdown
Owner

yes i'm from ESOC i'm extremely sorry for the incovinence but i have raised the issue before, i'll close the PR if that's the case

According to esoc team close or mark invalid until coding period starts

@Vaibhavi410

Copy link
Copy Markdown
Author

ohh okayy i'll keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide whether src/server/server/api.ts is still needed now that Next API routes exist; remove it if it is legacy.

5 participants