Sending attributes from <auth>/send section. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declaration changed. Class members m_thread, m_mutex added. Function Run declaration added.
handleReceive added.
find_package(OpenSSL 1.0.0 Required) added, OpenSSL::Crypto added to target_link_libraries command in the block if(BUILD_MOD_RADIUS).
definition changed. Method Stop: variable isRunning=false removed, m_thread.joinable check added, isRunning check added, request_stop call added. Method Run: parameter token added, variables secret, port removed, object lock and isRunning=true added before cycle while, cycle while added, isRunning=false added after cycle while.
for m_thread.join() removed in the Stop function.
m_errorStr in class Radius.
added to constructor RADIUS. Output cerr replaced by logger and printfd().
IsRunning definition added.
…nged to attributes and & added to parameter in the ShowRules function.
function declaration added. Class member m_auth, m_autz added. Unnecessary code removed.
definition and call added, MakeKeyValuePairs function removed, ParseSettings function changed. Extra printfd function added.
functions removed.
…r Server definition.
…in the function ShowRules.
declaration removed, struct Settings forward declaration removed.
<algorithm>, <ioservice> removed. Extra using declaration removed.
Functions definition of class RAD_SETTINGS removed. Parameter
m_radSettings added to Server constructor call.
…ed to constructor Server declaration. Class memberm_radSettings added.
… Class member m_radSettings initialization added in the constructor Server.
changed to const in constructor Server declaration. The bool findUser function declaration replaced by const User* findUser.
…arameter radSettings changed to const in constructor Server definition. The bool findUser function definition replaced by const User* findUser. The makeAttributes function definition added. Function makeResponse definition changed.
Conflicts resolved.
madf
requested changes
Sep 1, 2025
|
|
||
| <auth> | ||
| send = "Framed-IP-Address = currip, Service-Type = \'Framed-User\'" | ||
| send = "User-Name = login, Framed-IP-Address = currip, Service-Type = \'Framed-User\', Callback-Number = \'987654abc\'" |
Owner
There was a problem hiding this comment.
Let's keep the original value. It makes more sense.
| add_library ( mod_radius MODULE other/radius/radius.cpp | ||
| other/radius/server.cpp) | ||
| other/radius/server.cpp | ||
| other/radius/rad_settings.cpp) |
| : m_radius(io_context, secret, port), | ||
| m_dictionaries(filePath), | ||
| m_users(users), | ||
| m_radSettings(radSettings), |
Owner
There was a problem hiding this comment.
Let's call them settings and m_settings.
| } | ||
|
|
||
| RadProto::Packet Server::makeResponse(const RadProto::Packet& request) | ||
| std::vector<RadProto::Attribute*> Server::makeAttributes(const User* user) |
Owner
There was a problem hiding this comment.
I think this code is derived from the async-radius library, isn't it? If so, let's just expose it in the lib and use here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class RAD_SETTINGS is transferred to separate files .h / .cpp. The makeResponse function changed to send attributes configured in the /send section. Function makeAttributes added.