fix: setting member_options no longer unsets package on members#262
Merged
fix: setting member_options no longer unsets package on members#262
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where setting member_options in options, caused package and dynamic to be set back to their default values on the members
Caused the error:
Since it unset package from
quartodoc.MdRenderer, and fell back on the default packagequartodoc(in the top-level config).The gist is that blueprint uses a function called
_non_default_entriesto get only the arguments manually specified options (since pydantic automatically puts in the defaults, we need a way to get only the ones users manually specified). However, becausemember_optionsare nested insideAuto, and we were converting the pydantic Auto to a dict, we accidentally grabbed the defaults too there.