Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: Janitorial work for SplineFD #315

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

KSkwarczynski
Copy link
Member

Pull request description

Code should be nicer and faster (by small margin...)

Changes or fixes

  • vector -> const vector& for speed
  • Made templates to more easily clean std::vectors
  • Binning wasn't properly deleted
  • Find spline segment was making parraler but didn't use for, waste of resources...
  • In find spline segment xArray was copied... waste of resources...
  • lot of const for const corecctens...
  • introduce coeffOffset to avoid multiplciation by 4 so many times...
  • SetupSplines wasn't used so removed
  • addef fmaf_t to avoid total mess in calcsplinewieght...

Examples

Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples labels Jan 29, 2025
Copy link

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   310.04 MB |   313.74 MB |
| **CPU** |    92.40 %  |   118.75 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

Copy link
Contributor

@EdAtkin EdAtkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying :) makes it all neater.

@KSkwarczynski KSkwarczynski merged commit b87fbc8 into develop Feb 3, 2025
14 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_TidySplineCode branch February 3, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manager Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants