-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PDF Handler #312
feat: PDF Handler #312
Conversation
…g, for now only a struct
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this Use this action on your projects. Use jokes on issues instead. |
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage Summary
Memory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
This is going to get a bit messy since the proposed re-name of samplePDFX was going to be sampleHandlerX I think? |
On the contrary I think |
Pull request description
This introduce PDF Handler which is suppsoed to handle Data,MC predictions. For now is only a struct to not have too many objects in SamplePDF. In future I think we could move many of converting arrays to TH1 into class. Making it real prediction class.
I didn't want to spend too much time as I am unsure whether people like this idea or not.
Haven't checked but could have minor positive impact on performance. I intorduced this for T2K ND280 and there it helped.
Changes or fixes
Examples