Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PDF Handler #312

Closed
wants to merge 8 commits into from
Closed

feat: PDF Handler #312

wants to merge 8 commits into from

Conversation

KSkwarczynski
Copy link
Member

Pull request description

This introduce PDF Handler which is suppsoed to handle Data,MC predictions. For now is only a struct to not have too many objects in SamplePDF. In future I think we could move many of converting arrays to TH1 into class. Making it real prediction class.

I didn't want to spend too much time as I am unsure whether people like this idea or not.

Haven't checked but could have minor positive impact on performance. I intorduced this for T2K ND280 and there it helped.

Changes or fixes

Examples

Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

Copy link

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   270.11 MB |   310.66 MB |
| **CPU** |     7.91 %  |    13.75 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

@KSkwarczynski KSkwarczynski marked this pull request as draft January 28, 2025 10:15
@KSkwarczynski KSkwarczynski marked this pull request as ready for review January 28, 2025 14:09
@EdAtkin
Copy link
Contributor

EdAtkin commented Feb 3, 2025

This is going to get a bit messy since the proposed re-name of samplePDFX was going to be sampleHandlerX I think?

@KSkwarczynski
Copy link
Member Author

On the contrary I think
You will have SampleHandler and PDFHandler while the latter deal wihth Data/MC/W2 predicitons

@KSkwarczynski KSkwarczynski deleted the feature_fdPDF branch February 10, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants