Repository navigation
Improve network sync, ensure 100% Fireveil uptime, and clean up async logic - #9
Closed
Sasuke-2213 wants to merge 3 commits into
Closed
Sasuke-2213 wants to merge 3 commits into
Sasuke-2213 wants to merge 3 commits into
Conversation
Refactor: Improve network sync, ensure 100% Fireveil uptime, and clean up async logic
Owner
|
Why would you want the fireveil to trigger every 2nd catch? Unconditionally, no knowledge of whether anything spawned.
If you can come up with a better way to detect seacreature catches go ahead, the refactoring is half decent though bro you cannot read "perfectly balances high aura uptime with optimal mana conservation." with a straight face though like look me in the face and tell me that line isnt hilarious just because it sounds so much like a really old LLM from 2023 |
Owner
|
at further glance, there are so many more issues its best for you to scrap this PR and try again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fixes & Network Sync
ServerboundSetCarriedItemPacketcalls during slot swapping. VanillaMultiPlayerGameMode.useItem()already synchronizes the inventory automatically. Sending the packet manually caused redundant packets.✨ Logic Improvements
fireveilMessagesarray and the chat event listeners. Relying on exact string matching was fragile.♻️ Refactoring
scheduler.schedule -> client.executelambdas. Introduced ascheduleOnMainThread()helper method, flattening the sequence into clean, linear, and thread-safe steps.debugLog()helper. It now prints 3 formatted lines per catch cycle, displaying the exact millisecond delays for easy config tuning.onInitializeClient().