Build binaries for Linux, Windows, and macOS for every release #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to trigger a build which includes a static dependency to openssl by compiling it from source in a build.rs script. It is useful for Linux, which has wildly different config parameters for different architectures.
This allows us to pass the vendored-openssl feature flag to this dependency and compile openssl from source
|
Going ahead and merging this to unblock #64. We can always revisit this pipeline and fix any potential issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates lychee binaries for every release.
See #59 for more info.
Created a fake release here to show how the output looks like.
Some notes:
ringat the moment, which is a sub-dependency. reqwests has support for rustls through a feature flag, but I doubt that it supports mips either.openssl-sysas direct dependency. This allows us to pass thevendored-opensslfeature flag to this dependency and compile openssl from source.bruceadams/[email protected]to pull in the tag name from a release. This allows us to create a new release from the Github UI while the pipeline can still detected the respective tag for a release.