Skip to content

Conversation

@isf63
Copy link
Contributor

@isf63 isf63 commented Aug 17, 2025

QPushButton is generally styled "nicer" than QToolButton when the goal is dialog buttons. Tested on Fusion, Windows, and Kvantum themes.

Default focus was not an issue because it had default focus prior.

1 2 3 4

I think the same can be done in a few others places, if this has validity.

@tsujan
Copy link
Member

tsujan commented Aug 17, 2025

QPushButton is generally styled "nicer"

A matter of personal taste, not a reason to make a change. We talked about it before.

@isf63
Copy link
Contributor Author

isf63 commented Aug 17, 2025

IMHO I think it's more than personal taste.

QDialogButtonBox and liblxqt use QPushButton's for a reason.

QToolButton has lousy styling with text + icon. It's primarily meant for toolbar or drop-down menus. See screenshots, I think this is fairly objective.

The only other place right now that I see benefiting from this (if this is sane) is Monitor Settings → Settings. Qt::TabFocus can be set to have no functional difference.

@tsujan
Copy link
Member

tsujan commented Aug 17, 2025

QToolButton has lousy styling with text + icon.

The same personal taste put into a totally subjective statement again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants