incusd: Deprecate gorilla/mux #2451
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xk1f0 <[email protected]>
Signed-off-by: 0xk1f0 <[email protected]>
Signed-off-by: 0xk1f0 <[email protected]>
|
Mark as Draft until the regressions can be sorted out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already determined in #2259, it would make sense to start phasing out
gorilla/muxin all of incus, this PR aims to do just that.Worth noting that
http.ServeMuxdoes not implement aNotFoundHandler, but since we already overwriteServeHTTP, I tried to do a trivial reimplementation of it, which just checks if aHandlerfor a given route exists and executes a supplied function if not.Most of the other changes here consist of replacing
mux.Vars(r)[]withr.PathValue(). This all builds fine, but I have not extensively tested this yet, which is on my to-do list for the next coming days.