Skip to content

fix: reject manifest CRLF bypasses - #2040

Merged
ken-jo merged 1 commit into
mainfrom
agent/manifest-crlf-validation
Aug 10, 2026
Merged

fix: reject manifest CRLF bypasses#2040
ken-jo merged 1 commit into
mainfrom
agent/manifest-crlf-validation

Conversation

@ken-jo

@ken-jo ken-jo commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an explicit CR/LF negative guard to every pattern-constrained host manifest field
  • add a recursive regression test so future pattern fields cannot omit the guard
  • reject terminal LF/CR in plugin IDs and minimum app versions

Why

ECMAScript-style regular-expression end anchors can match before a terminal line feed. The schema therefore needs an explicit negative guard rather than relying on $ alone.

Validation

  • bun run typecheck
  • focused Electron Vitest: 1 file, 39 tests
  • pre-push: 1,012 passed files / 1 skipped; 12,886 passed tests / 43 skipped
  • full build and static policy gates passed

Companion SDK and Marketplace snapshots are being updated separately.

@ken-jo
ken-jo marked this pull request as ready for review August 10, 2026 06:03
@ken-jo
ken-jo merged commit 8278bd4 into main Aug 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant