test: clean temporary tool directories - #2037
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Seven reachable temporary-directory allocations in the Tools test area had no teardown contract. Three permission paths discarded the allocated root immediately, one persisted-permission test kept the root but never removed it, and three executable-resolution fixtures were not registered for cleanup. Repeated runs could therefore leave OS temporary directories behind.
Scope
Impact and risk
This is test-only lifecycle hardening across three Tools test files. Runtime behavior and production contracts are unchanged. Risk is limited to teardown ordering; cleanup runs only after each test's resources and writes have completed.
Validation