Drain permission cache rewrites before test cleanup - #2036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Permission tests created scratch directories without deterministic teardown. A separate cache lifecycle race made cleanup unsafe: synchronous stale or expired lookups schedule a background cache rewrite, so removing the directory immediately could race an in-flight writer.
Scope
Impact and risk
Runtime permission decisions, cache keys, TTL, invalidation, and fail-closed behavior are unchanged. The production change only exposes completion for already-scheduled cache rewrites. Test teardown now removes its owned scratch state deterministically and remains retryable when teardown itself fails.
Risk is low and localized to the reviewer cache writer lifecycle and test-only teardown. No UI, IPC, schema, persisted authoritative data, dependency, or companion-repository changes are included.
Validation
UI or E2E evidence: not applicable; no user interface behavior changed.
Companion repository PRs: none.